Skip to content

Conversation

@libanj0161
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist
I created a form to collect customer data. The form consists of their name, email, t-shirt colour and size. I used only HTML. All the inputs have labels they are associated with. I scored 100 in the Lighthouse Accessibility score. Their name and email has to be a valid one and they can only pick one colour and size out of the options given.

Questions
N/A.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e4a809e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6978c5e73906f20007cfa350
😎 Deploy Preview https://deploy-preview-1082--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@libanj0161 libanj0161 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 27, 2026
<input id="Extra Extra Large"type="radio" name="size" value="XXL" />
<label for="Extra Extra Large">Extra Extra Large</label> <br>


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we submit the form? is there an element to use to submit the form ?

<br>

<p>Size</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done for the good work.
just a few more things to do
can we use a dropdown menu () for the sizes ? when should you use radio buttons and drop down menu ()
see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select

</p>
<p>
<label for="mail">Email</label>
<input type="email" id="mail" name="user_email" />
Copy link

@takanocap takanocap Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a placeholder to guide the users?
can we check for a minlength too ?
is there a way to validate the inputs?
can we use an attribute for the validation?

</p>
<p>Colour</p>

<label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an attribute to associate the label with the radio button ?

@takanocap takanocap added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 27, 2026
<form>
<p>
<label for="name">Name</label>
<input type="text" id="name" name="user_name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a minlength and other attribute to validate or make sure the input is required ?
can we use the placeholder to guide the users ?

@takanocap takanocap self-assigned this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants